This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Special handling of "%H" (Re: Support for %d$c format specifierin diagnostics.c)

"Joseph S. Myers" <jsm@polyomino.org.uk> writes:

| On Thu, 31 Jul 2003, Ishikawa wrote:
| 
| > Ok, while I am waiting for the patch to support positional format
| > specifiers in diagnostic (and formated output) routines being merged
| > into mainline tree (hint, hint), I looked at
| 
| For the detailed review process to start, please submit a version of the
| patch formatted according to the GNU Coding Standards.  (There may then
| need to be several rounds of technical review of the patch following
| that.)

I have been looking at his code -- no I didn't reach the conclusion
I'm satisfied yet.  For future resubmission I would suggest he avoid
_[a-z]* and instead use the "pp_" prefix instead (or better).

-- Gaby
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]