Re: Final intermodule patch

[Geoffrey Keating <geoffk at apple dot com>]

On Monday, July 28, 2003, at 02:53  PM, Krister Walfridsson wrote:

> On Fri, 11 Jul 2003, Geoffrey Keating wrote:
>
> > There are a few changes since the last version.  The most notable is
> > the __attribute__((used)) changes; the previous implementation was
> > broken, assuming that DECL_ASSEMBLER_NAME was valid when the decl
> > wasn't even fully parsed yet!  Also, there's a new C_DECL_FILE_SCOPE
> > macro, and it's used in more places.
> >
> > Bootstrapped & tested on powerpc-darwin.  Being committed now.
>
>
> This chaneg cause 5 new testsuite failures
>
>    FAIL: gcc.c-torture/execute/alloca-1.c execution,  -O0
>    FAIL: gcc.c-torture/execute/alloca-1.c execution,  -O1
>    FAIL: gcc.c-torture/execute/alloca-1.c execution,  -O2
>    FAIL: gcc.c-torture/execute/alloca-1.c execution,  -O3 
> -fomit-frame-pointer
>    FAIL: gcc.c-torture/execute/alloca-1.c execution,  -O3 -g
>
> for i386-unknown-netbsdelf1.6.
>
> What is happening is that the compiler "forgets" to align the stack
> before doing a function call.

*boggle*

I can't imagine what nonsense must be going on for that patch to have 
that effect.

Does the problem still happen with current mainline?

--
Geoff Keating <geoffk@apple.com>