This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: 3334280


Dale Johannesen <dalej@apple.com> writes:

> [...]
> -             op0 = gen_lowpart_for_combine (tmode, op0);
> +             /* APPLE LOCAL ban undefined SUBREG */

Do you really like to add this?

> +             /* We can't accept a (necessarily paradoxical) SUBREG
> +                here, as the high bits of it are undefined. */

Two spaces after a period, please.

> +             new_op0 = gen_lowpart_for_combine (tmode, op0);
> +             new_op1 = gen_lowpart_for_combine (tmode, op1);
> +             if (GET_CODE (new_op0) != SUBREG
> +                 && (op1 == new_op1 || GET_CODE (new_op1) != SUBREG))
> +               {
> +                 op0 = new_op0;
> +                 op1 = new_op1;
>                if (zero_extended && GET_CODE (op1) == CONST_INT)
>                  op1 = GEN_INT (INTVAL (op1) & GET_MODE_MASK (mode));
> -             op1 = gen_lowpart_for_combine (tmode, op1);
>                break;
> +               }
>              }

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]