This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: cpplib: Small tweak to cppfiles.c

From: Neil Booth <neil at daikokuya dot co dot uk>
To: Zack Weinberg <zack at codesourcery dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 21 Jul 2003 22:58:26 +0100
Subject: Re: cpplib: Small tweak to cppfiles.c
References: <20030721205513.GL22306@daikokuya.co.uk> <87u19fpmun.fsf@egil.codesourcery.com>

Zack Weinberg wrote:-

> > When trying to figure out what PCH was doing with files, I
> > noticed some stuff was redundant.  Regtested with no regressions.
> >
> > Neil.
> >
> > 	* cppfiles.c (open_file_pch): Don't put unused entries in the
> > 	splay tree.  Remove dead code.
> 
> Putting entries in the splay tree for files that don't exist is
> deliberate - it saves us trying to open them again the next time
> that file is referenced.  Or am I confused about which entries you're
> talking about?

I don't believe the splay tree entry was used at all.  The only
purpose of the call was to simplify the pathname, so I put that inline.

Neil.

References:
- cpplib: Small tweak to cppfiles.c
  - From: Neil Booth
- Re: cpplib: Small tweak to cppfiles.c
  - From: Zack Weinberg

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]