This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: peeling more bits off the onion
On Sat, 2003-07-19 at 10:01, Gabriel Dos Reis wrote:
> "Zack Weinberg" <zack@codesourcery.com> writes:
>
> | Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
> |
> | > "Zack Weinberg" <zack@codesourcery.com> writes:
> | >
> | > | Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
> | > |
> | > | > Last time I was working one this sort of thing, Mark, Jason and I
> | > | > agreed it is ugly and wrong that poplevel() is being called from
> | > | > there (by language independent code). We agree that should not
> | > | > happen. so instead of preserving that hack, I would rather we get
> | > | > rid of it.
> | > |
> | > | I totally agree that poplevel and pushlevel should not be called from
> | > | language independent code, but I have a specific goal in mind, and it
> | > | does not include fixing this.
> | >
> | > The point is, if you're going to make that look "better" then don't
> | > preserve it by inventing enums around it.
> |
> | You want I should change KEEP_MAYBE to the magic number 2 everywhere
> | it appears?
>
> For the purpose of actively saying "this needs fixing"? Yes.
I understand the motivation behind Gaby's argument, but I don't think
that's the right solution.
Making it an enum/define makes the code easier to read, and we may be
stuck with this piece of ugliness for years yet, so let's make sure that
we can make sense out of it.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com