This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: C++ PATCH: fix PC 10903


On Wed, Jul 16, 2003 at 03:42:52AM +0200, Gabriel Dos Reis wrote:
> *** cp/ChangeLog	16 Jul 2003 01:41:40 -0000
> --- cp/ChangeLog	16 Jul 2003 00:09:41 -0000	1.3526
> ***************
> *** 1,9 ****
> - 2003-07-16  Gabriel Dos Reis  <gdr@integrable-solutions.net>
> - 
> - 	PR c++/10903
> - 	* pt.c (convert_nontype_argument): Fix thinko in diagnostic.
> - 	Improve.
> - 

Both the changelog entry and the testcase show up as removals rather
than additions.  Could you check that please, just to be safe?



> *************** convert_nontype_argument (tree type, tre
> *** 3085,3098 ****
>       }
>     else 
>       {
> !       if (TYPE_P (expr))
> !         error ("type '%T' cannot be used as a value for a non-type "
> !                "template-parameter", expr);
> !       else if (DECL_P (expr))
> !         error ("invalid use of '%D' as a non-type template-argument", expr);
> !       else
> !         error ("invalid use of '%E' as a non-type template-argument", expr);
> ! 
>         return NULL_TREE;
>       }
>   
> --- 3085,3091 ----
>       }
>     else 
>       {
> !       error ("object `%E' cannot be used as template argument", expr);
>         return NULL_TREE;
>       }

People might get confused about the use of "object" here.  What do you
think of something like

      error ("`%E' cannot be used as a non-type template argument", expr);


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]