This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [tree-ssa] [PATCH]: Fix DCE not updating bb->end_tree_p
- From: Diego Novillo <dnovillo at redhat dot com>
- To: Andrew Macleod <amacleod at redhat dot com>
- Cc: Daniel Berlin <dberlin at dberlin dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: 15 Jul 2003 18:27:12 -0400
- Subject: Re: [tree-ssa] [PATCH]: Fix DCE not updating bb->end_tree_p
- Organization: Red Hat Canada
- References: <Pine.LNX.4.56.0307151653190.20692@dberlin.org> <1058307902.28825.370.camel@p4>
On Tue, 2003-07-15 at 18:25, Andrew MacLeod wrote:
> > + {
> > + block_stmt_iterator bsi;
> > + bsi = bsi_start (bb);
> > + while (bsi_stmt_ptr (bsi) != stmt_p)
> > + bsi_next_in_bb (&bsi, bb);
> > + bsi_prev (&bsi);
> > + bb->end_tree_p = bsi_container (bsi);
> > + }
> > +
> > stmt->common.ann = NULL;
> >
> > /* The RHS of a MODIFY_EXPR has an annotation for the benefit of
>
> gah. You realize that bsi_prev() currently redoes what you just did all
> over again, so you are currently iterating from bsi_start() twice?
>
Oh, right, I missed that, sorry :/
We really, really, really need to change the way we link statements.
Diego.