This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Allow options.[ch] to be possibly regenerated after reconfigure --enable-languages=xxx
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Kelley Cook <KelleyCook at wideopenwest dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Neil Booth <neil at daikokuya dot co dot uk>
- Date: 08 Jul 2003 19:39:19 -0300
- Subject: Re: [Patch] Allow options.[ch] to be possibly regenerated after reconfigure --enable-languages=xxx
- Organization: GCC Team, Red Hat
- References: <3F0B1501.1060505@ford.com><oradbovnd1.fsf@free.redhat.lsd.ic.unicamp.br><3F0B3E11.3040809@ford.com>
On Jul 8, 2003, Kelley Cook <kcook34@ford.com> wrote:
> Alexandre Oliva wrote:
>> On Jul 8, 2003, Kelley Cook <kcook34@ford.com> wrote:
>>
>>> b) Because of a) I ended up hardcoding "options.h" in the generated
>>> "options.c" otherwise it was being created with '#include
>>> "tmp-options.h"' This may not be palatable to you in which case I am
>>> open to other suggestions
>> Maybe move the move-if-change commands into opts.sh, and get opts.sh
>> to choose the temporary names itself?
> A most excellent idea, how's this?
Looks good, but I'd still tweak it a bit further. You should use
${SHELL} to run shell-scripts such as move-if-change, so how about
passing "$(SHELL) $(srcdir)/move-if-change"?
> 2003-07-08 Kelley Cook <kelleycook@wideopenwest.com>
> * Makefile.in (options.h): Depend on Makefile. Add in $(srcdir)
> to opts.sh command line.
> * opts.sh: Write to temporary files with a move-if-change at the end.
This is ok, but I'd prefer the change suggested above to go in, even
if as a separate patch.
Thanks,
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer