This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Totally Fix PR target/10129 ADA bootstrap failure on Darwin
- From: Geoff Keating <geoffk at geoffk dot org>
- To: pinskia at physics dot uc dot edu
- Cc: pinskia at physics dot uc dot edu, gcc-patches at gcc dot gnu dot org
- Date: Mon, 7 Jul 2003 18:18:32 -0700
- Subject: Re: [PATCH] Totally Fix PR target/10129 ADA bootstrap failure on Darwin
- References: <DD83BDA0-B0BE-11D7-866C-000393A6D2F2@physics.uc.edu>
> X-Original-To: geoffk@foam.wonderslug.com
> Date: Mon, 7 Jul 2003 17:06:23 -0400
> From: Andrew Pinski <pinskia@physics.uc.edu>
This is excellent! Thank you!
> > - The comments need to be rechecked. Some of the old ones are no
> > longer right, and the new ones are not formatted properly. You
> > should never say that something is the 'new way' in a comment, since
> > it won't be new in 10 years time, and the comment will still be
> > around; just say how the existing code works.
>
> I Removed the "New" comment and the static comment because that comment
> no longer
> applies.
In the patch you sent, the comment wasn't removed:
> @@ -218,54 +222,50 @@ machopic_define_name (name)
> machopic_define_ident (get_identifier (name));
> }
>
> -/* This is a static to make inline functions work. The rtx
> - representing the PIC base symbol always points to here.
>
> - FIXME: The rest of the compiler doesn't expect strings to change. */
> +/* This is a static to make inline functions work. The rtx
> + representing the PIC base symbol always points to here. */
>
> static GTY(()) char * function_base;
Otherwise, the patch is OK. Please double-check that the comment is
removed, and then commit it!
--
- Geoffrey Keating <geoffk@geoffk.org>