This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Totally Fix PR target/10129 ADA bootstrap failure on Darwin
- From: Geoff Keating <geoffk at geoffk dot org>
- To: pinskia at physics dot uc dot edu
- Cc: pinskia at physics dot uc dot edu, gcc-patches at gcc dot gnu dot org
- Date: Sun, 6 Jul 2003 16:56:25 -0700
- Subject: Re: [PATCH] Totally Fix PR target/10129 ADA bootstrap failure on Darwin
- References: <D3AAE5E6-AD8F-11D7-9AE0-000393A6D2F2@physics.uc.edu>
This patch looks like the right direction, but it could do with some
cleaning up:
- The comments need to be rechecked. Some of the old ones are no
longer right, and the new ones are not formatted properly. You
should never say that something is the 'new way' in a comment, since
it won't be new in 10 years time, and the comment will still be
around; just say how the existing code works.
- It doesn't remove the FIXME. The FIXME is the underlying cause of
these problems. In fact, I think it makes it worse by creating two
strings that are modified instead of one. There's no need to
allocate the string using GCC if it's only going to be passed
directly to printf, you can just use a static variable.
- The objective-C stuff should go. I think it's no longer used,
but you'd want to test that.
- I bet this breaks x86-darwin.
- What's with the change to darwin_encode_section_info?
--
- Geoffrey Keating <geoffk@geoffk.org>