This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] PR debug/10055: fix input_filename clobber
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Michael Elizabeth Chastain <mec at shout dot net>
- Cc: gcc-patches at gcc dot gnu dot org, neil at daikokuya dot co dot uk
- Date: 06 Jul 2003 15:37:27 -0700
- Subject: Re: [RFA] PR debug/10055: fix input_filename clobber
- Organization: CodeSourcery, LLC
- References: <200307061839.h66Id3ng031594@duracef.shout.net>
On Sun, 2003-07-06 at 11:39, Michael Elizabeth Chastain wrote:
> This patch fixes PR gdb/10055, a regression from gcc 3.3.
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10055
> [3.4 regression] g++ emits "<internal>" as source filename with -gstabs+
>
> The problem happens with g++ -gstabs+. g++ emits a BINCL stab for
> "<internal>" rather than the name of the input file. This makes
> debugging more difficult and causes dozens of FAIL results in the gdb
> test suite.
>
> The problem is with the initialization order of input_filename.
> Here is a sketch of the call tree:
This patch is OK -- but remove the first-person comment. Just write:
We cannot just assign to input_filename because it has already been
initialized and will be used later as an N_BINCL for stabs+ debugging.
Neil, do you have time to apply this to 3.4 for Michael?
Thanks,
--
Mark Mitchell <mark@codesourcery.com>
CodeSourcery, LLC