This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] take 2: PR/11368 clearer documentation on -falign-*


Using Jim Wilson's suggestion of using -falign-functions as a model
and adding information about what does 0 mean, machine-dependent default,
I updated my patch.


ChangeLog:
2003-07-05  Andrew Pinski <pinskia@physics.uc.edu>

	* doc/invoke.texi (-falign-functions): Document that
	when n is zero then a machine-dependent default is used.
	(-falign-labels): Document that when n is zero then a
	machine-dependent default is used and that -falign-labels =1
	is equivalent to -fno-align-labels.
	(-falign-loops): Likewise.
	(-falign-jumps): Likewise.


Patch:

Attachment: temp.diff
Description: Binary data



Thanks,
Andrew Pinski

On Friday, Jul 4, 2003, at 03:06 US/Eastern, Jim Wilson wrote:

>+If @var{n} is one, meaning no alignment.

This looks ungrammatical to me. Maybe "@var{n} means no alignment.", or "If @var{n} is one, this means no alignment."

In the -falign-functions case, there is already a sentence that documents that -falign-functions=1 is equivalent to -fno-align-functions. So adding this sentence is redundant. I like this wording of this sentence. I'd suggest duplicating this sentence into the other 3 -falign-* options, instead of adding the sentence you wrote above.

We then end up with redundancy in the -falign-labels, because it already says one means no alignment, but we could the tail end of that sentence to solve the problem.

>-If @var{n} is not specified, use a machine-dependent default.
>+If @var{n} is not specified or is zero, use a machine-dependent default.


This part is fine.

Jim




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]