This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [distcc] gcc bootstraps with distcc
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Alexandre Oliva <oliva at lsd dot ic dot unicamp dot br>
- Cc: mbp at sourcefrog dot net, gcc-patches at gcc dot gnu dot org, Dara Hazeghi <dhazeghi at yahoo dot com>, distcc at lists dot samba dot org, Thomas Walker <Thomas dot Walker at morganstanley dot com>
- Date: Tue, 01 Jul 2003 23:09:24 -0700
- Subject: Re: [distcc] gcc bootstraps with distcc
- References: <20030619033358.63559.qmail@web41114.mail.yahoo.com><20030619104500.GE27331@wistful.sourcefrog.net><orbrwdzgc4.fsf@free.redhat.lsd.ic.unicamp.br>
Alexandre Oliva <oliva@lsd.ic.unicamp.br> writes:
>
> The patch introduces -Mpwd, that causes GCC to output the
> preprocessing directory in the preprocessed output. This means you
> have to add -Mpwd to BOOT_CFLAGS to get a successful bootstrap, as
> well as to get gdb to find source files in their original location,
> even if using only ccache but using several different yet similar
> source and build trees. The reasons -Mpwd is not enabled by default
> are backward compatibility (the <directory> directive might be
> unexpected, even though it's in a format that is entirely
> backward-compatible), efficiency and to enable ccache caches to be
> shared by multiple build trees.
(1) I'm with Neil, this should be a separate hook; don't overload
cb_file_change even more.
(2) I don't think backward compatibility is a major concern here. I
would rather you used # 1 "/path/to/whatever/" 5 or something like
that. Also, I'd rather you put it before the initial LC_ENTER note.
However, this is nitpicking, I'm not opposed to what you did. I
do think there's no reason not to make this unconditional.
(3) Whatever's done, you need to document the new marker in the manual
section describing the form of preprocessed output.
zw