This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix rtl sharing in ifcvt try 2
- From: Jan Hubicka <jh at suse dot cz>
- To: Richard Henderson <rth at redhat dot com>, Jan Hubicka <jh at suse dot cz>,gcc-patches at gcc dot gnu dot org
- Date: Tue, 1 Jul 2003 22:28:20 +0200
- Subject: Re: Fix rtl sharing in ifcvt try 2
- References: <20030627195134.GF1455@kam.mff.cuni.cz> <20030630170111.GB23670@redhat.com> <20030630170720.GC8100@kam.mff.cuni.cz> <20030630195051.GA23718@redhat.com> <20030701175521.GK10884@kam.mff.cuni.cz> <20030701201115.GA14389@redhat.com>
> On Tue, Jul 01, 2003 at 07:55:21PM +0200, Jan Hubicka wrote:
> > I also had to do checking not before reload, but before insn splitting
> > as insn splitting introduces plenty of sharing.
>
> That would be a bug.
OK, I will make try_split to unshare rtl next.
>
> > Should I care unsharing in try_split?
>
> Possibly.
>
> I'd also like to see this pass run before regrename_optimize,
> where this sharing problem has also caused problems in the past.
You mean that regrename has caused rtl sharing, or rtl sharing has
broken regrename? In the first case I think we should run it afterwards
and in the second case I would guess so to as regrename will unlikely
elliminate the sharing so we will get more checking then...
Honza
>
> The patch is ok.
>
>
> r~