This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for diagnostics format warnings in gcc dir
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: gdr at integrable-solutions dot net
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 1 Jul 2003 14:33:16 -0400 (EDT)
- Subject: Re: Patch for diagnostics format warnings in gcc dir
- References: <200306301601.MAA05382@caip.rutgers.edu> <m34r26mdcc.fsf@uniton.integrable-solutions.net>
> From: Gabriel Dos Reis <gdr@integrable-solutions.net>
>
> "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
>
> | This patch fixes a couple of diagnostics format warnings in the top
> | level gcc directory.
> |
> | The first bit was needed because the '#' flag isn't supported by the C
> | frontend diagnostics format, and c-semantics.c is linked with cc1.
>
> While the change you're proposing makes sense, the diagnostic format
> checker in cc1 should be thaught to accept '#'.
Sure although IMHO updating the format checker should be done after
the format *parser* is updated. If you do that, I'd be happy to
modify the `cdiag' checker. Then we can put the '#' back.
> | The second bit was a simple HOST_WIDE_INT mismatch, fixed with the new
> | 'w' length modifier.
> |
> | Bootstrapped on sparc-sun-solaris2.7 (minus java), no regressions.
> |
> | Ok for mainline?
>
> Yes,
> -- Gaby
Thanks, installed.
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu