This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Eliminated poisoned macro use in kaos.h


Uwe Stieber <uwe@kaos-group.de> writes:

> Hi,
>
>> It concerns me that this file was added without having been tested in
>> the first place.
>
> The macro CPP_PREDEFINES is poisoned since last month. This is not very long. 
> The file worked fine with GCC 3.2.x and GCC 3.3.x. The orginal submit of the 
> patch were february 2003.

The file was commited on 2003-06-11.  So, at this point the GCC patch
rules force the committer to reevaluate the patch and make needed
changes.  Unfortunatly this was not done - and this is the real
problem we're facing here and I agree with Neil's remark, the file was
not tested properly.


> Well, above is surely no excuse, but the only thing I can do is to catch up 
> with the list of poisoned macros as soon as I discovered the issue. And that 
> is what I have done with submitting the change almost immediately after I 
> discovered the problem and removes the use of CPP_PREDEFINES.

If the patch would have been in, whoever has done the poisoining
should have changed the kaos.h file also.  But at the time the
poisoining happened, kaos.h was not committed and therefore could have
not been changed at all.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]