This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Stripped down unit-at-a-time fix
- From: Richard Henderson <rth at redhat dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 23 Jun 2003 13:49:34 -0700
- Subject: Re: Stripped down unit-at-a-time fix
- References: <20030621222344.GA23405@kam.mff.cuni.cz>
On Sun, Jun 22, 2003 at 12:23:44AM +0200, Jan Hubicka wrote:
> + cgraph_node_for_identifier (id)
> + tree id;
> + {
> + struct cgraph_node **slot;
> +
> + if (TREE_CODE (id) != IDENTIFIER_NODE)
> + abort ();
> +
> + if (!cgraph_hash)
> + {
> + cgraph_hash = htab_create (10, hash_node, eq_node, NULL);
> + VARRAY_TREE_INIT (known_fns, 32, "known_fns");
> + }
Same comment here wrt returning NULL. I find it unlikely that
creating the data structures here is useful.
The rest of it looks ok.
r~