This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Empty BINCL/EINCL
- From: Geoff Keating <geoffk at geoffk dot org>
- To: Devang Patel <dpatel at apple dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 20 Jun 2003 12:22:36 -0700
- Subject: Re: [PATCH] Empty BINCL/EINCL
- References: <F126545B-A351-11D7-8272-000393A91CAA@apple.com>
Hi Devang,
+ static void emit_bincl_stab PARAMS ((const char *));
For new code, ISO C should be used, so no PARAMS, and no old-style
function definitions.
+ /* If zero then there is no pending BINCL */
This comment needs to be a full sentence, like:
/* If zero then there is no pending BINCL. */
and there are a few more like this:
+ enum binclstatus bincl_status; /* Keep track of lazy bincl */
+ const char *pending_bincl_name; /* Name of bincl */
+ struct dbx_file *prev; /* Chain to traverse all pending bincls */
+ /* Find first pending bincl */
+ /* Now emit all bincls */
+ /* Update file number and status */
This comment:
+ /* Do not assign file number now. Delay it until we actually emit BINCL. */
hould have two spaces after the '.'.
With these minor formatting changes, the patch is OK.
--
- Geoffrey Keating <geoffk@geoffk.org>