This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] avr: Remove -mrtl.


Hi Marek,

> > Attached is a patch to remove -mrtl.  AFAICT, -mrtl does the same
> > thing as -dP, except that -mrtl uses C style comment instead of ';'
> > and does not print the insn length.  -mrtl is not documented, so I
> > don't touch doc/*.texi.
> 
> Also, -msize does almost the same thing as -dp.

It also prints rtx_cost and the address of each instruction.  Shall we
remove the insn length portion from -msize?

> > Built cc1 and libgcc.   OK to apply?
> 
> As far as I am concerned, OK.  But, these options come from the
> very early days of the AVR port (when GCC was still called EGCS,
> and there was no -dP option yet), so I think Denis should decide.

I'll wait for him then.

> > @@ -69,7 +68,6 @@
> >  /* Dump each assembler insn's rtl into the output file.
> >     This is for debugging the compiler itself.  */
> >  
> > -#define TARGET_RTL_DUMP		(target_flags & MASK_RTL_DUMP)
> 
> While you are at it, remove the comment above the define too :)

OK.  Here is an updated patch.

Kazu Hirata

2003-06-20  Kazu Hirata  <kazu@cs.umass.edu>

	* config/avr/avr.c (final_prescan_insn): Remove support for
	-mrtl.
	* config/avr/avr.h (MASK_RTL_DUMP): Remove.
	(TARGET_RTL_DUMP): Likewise.
	(TARGET_SWITCHES): Remove -mrtl.

Index: avr.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/avr/avr.c,v
retrieving revision 1.94
diff -u -r1.94 avr.c
--- avr.c	7 Jun 2003 17:11:42 -0000	1.94
+++ avr.c	20 Jun 2003 13:19:04 -0000
@@ -1448,13 +1448,6 @@
 	       rtx_cost (PATTERN (insn), INSN));
     }
   last_insn_address = INSN_ADDRESSES (uid);
-
-  if (TARGET_RTL_DUMP)
-    {
-      fprintf (asm_out_file, "/*****************\n");
-      print_rtl_single (asm_out_file, insn);
-      fprintf (asm_out_file, "*****************/\n");
-    }
 }
 
 /* Return 0 if undefined, 1 if always true or always false.  */
Index: avr.h
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/avr/avr.h,v
retrieving revision 1.85
diff -u -r1.85 avr.h
--- avr.h	17 Jun 2003 08:06:54 -0000	1.85
+++ avr.h	20 Jun 2003 13:19:05 -0000
@@ -44,7 +44,6 @@
 /* This declaration should be present. */
 extern int target_flags;
 
-#define MASK_RTL_DUMP		0x00000010
 #define MASK_ALL_DEBUG		0x00000FE0
 #define MASK_ORDER_1		0x00001000
 #define MASK_INSN_SIZE_DUMP	0x00002000
@@ -65,11 +64,6 @@
 #define TARGET_TINY_STACK	(target_flags & MASK_TINY_STACK)
 #define TARGET_NO_TABLEJUMP	(target_flags & MASK_NO_TABLEJUMP)
 #define TARGET_SHORT_CALLS	(target_flags & MASK_SHORT_CALLS)
-
-/* Dump each assembler insn's rtl into the output file.
-   This is for debugging the compiler itself.  */
-
-#define TARGET_RTL_DUMP		(target_flags & MASK_RTL_DUMP)
 #define TARGET_ALL_DEBUG	(target_flags & MASK_ALL_DEBUG)
 
 #define TARGET_SWITCHES {						\
@@ -86,7 +80,6 @@
     N_("Do not generate tablejump insns") },				\
   { "short-calls", MASK_SHORT_CALLS,					\
     N_("Use rjmp/rcall (limited range) on >8K devices") },		\
-  { "rtl", MASK_RTL_DUMP, NULL },					\
   { "size", MASK_INSN_SIZE_DUMP,					\
     N_("Output instruction sizes to the asm file") },			\
   { "deb", MASK_ALL_DEBUG, NULL },					\


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]