This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR debug/4252
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Bob Abeles <rabeles at archaelogic dot com>
- Cc: Neil Booth <neil at daikokuya dot co dot uk>, gcc-patches at gcc dot gnu dot org
- Date: 17 Jun 2003 21:22:37 -0300
- Subject: Re: [patch] Fix PR debug/4252
- Organization: GCC Team, Red Hat
- References: <A32A23C8-A11A-11D7-A207-00306543ABD2@archaelogic.com>
On Jun 17, 2003, Bob Abeles <rabeles@archaelogic.com> wrote:
> 2003-06-17 Robert Abeles <rabeles@archaelogic.com>
> * java/lang.c (java_handle_option): Likewise.
> * cp/optimize.c (dump_function): Form complete flag name by
> prefixing 'fdump-' to string returned by dump_flag_name().
Just one nit: java and cp have their own ChangeLogs, so you should
instead provide separate entries for them, without java/ or cp/ in the
file names. Also, consider using the -p switch to diff, such that the
function name is listed in the patch file too: this also helps writing
ChangeLog entries :-)
I'm not entitled to approve your patch, but it definitely looks good
to me, and you got Neil's attention anyway, so I guess it's going in
soon. Thanks, and welcome aboard :-)
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer