This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cpplib: convert to C89 function definitions


> This patch raises a style question: In several places we now have
> 
> static int foo (int, int);
> static int
> foo (int a, int b)
> { ... }
> 
> Do we want to keep the separate prototype?  I can make a case either
> way; having the prototypes makes life easier if another function ever
> gets inserted above foo, but it is kind of odd-looking and you have to
> change two places if you change the function signature.  For now I'm
> not changing it.

I personally appreciate the separate prototypes.

-eric

-- 
Eric Christopher <echristo@redhat.com>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]