This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Minor cleanup in gencheck.c

From: Andreas Jaeger <aj at suse dot de>
To: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
Cc: gcc-patches at gcc dot gnu dot org
Date: Sun, 15 Jun 2003 18:48:50 +0200
Subject: Re: Minor cleanup in gencheck.c
References: <10306151638.AA23159@vlsi1.ultra.nyu.edu>

kenner@vlsi1.ultra.nyu.edu (Richard Kenner) writes:

>     > No.  Instead I checked the tree-check.h file to make sure it did the
>     > right thing.
>
>     In that case: Please revert the patch since it does not qualify the
>     formal criteria for a patch as mentioned in
>     http://gcc.gnu.org/contribute.html.
>
> Ummm.. it's *better* to check the output of the file than to do the
> bootstrap.  In a case like this, the bootstrap proves little, but checking
> the file indicates whether things are working as intended or not.

Oh, the generated file?  Yeah, that's a good check - but you didn't
state this in the initial mail and a full bootstrap is always a
prerequisite for checking in!

Andreas
-- 
 Andreas Jaeger, SuSE Linux AG, aj@suse.de, http://www.suse.de/~aj
  GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

References:
- Re: Minor cleanup in gencheck.c
  - From: Richard Kenner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]