This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] check-abi improvements
- From: Phil Edwards <phil at jaj dot com>
- To: Benjamin Kosnik <bkoz at redhat dot com>
- Cc: aj at suse dot de, gcc-patches at gcc dot gnu dot org
- Date: Sat, 14 Jun 2003 02:03:04 -0400
- Subject: Re: [v3] check-abi improvements
- References: <20030611115139.6b1d3963.bkoz@redhat.com> <20030612200801.GA661@disaster.jaj.com> <20030612151725.1b8003f4.bkoz@redhat.com> <20030612204505.GA939@disaster.jaj.com> <20030614001946.6ccd8238.bkoz@redhat.com>
> *** 455,463 ****
> dnl from GLIBCPP_CHECK_WCHAR_T_SUPPORT:
> AM_CONDITIONAL(GLIBCPP_TEST_WCHAR_T, test "$enable_wchar_t" = yes)
> dnl from GLIBCPP_CONFIGURE_TESTSUITE:
> ! # Don't do ABI checking unless native.
> ! AM_CONDITIONAL(GLIBCPP_BUILD_ABI_CHECK,
> ! ${GLIBCPP_IS_CROSS_COMPILING} && test "$enable_abi_check" = yes )
>
> AC_CACHE_SAVE
>
> --- 455,461 ----
> dnl from GLIBCPP_CHECK_WCHAR_T_SUPPORT:
> AM_CONDITIONAL(GLIBCPP_TEST_WCHAR_T, test "$enable_wchar_t" = yes)
> dnl from GLIBCPP_CONFIGURE_TESTSUITE:
> ! AM_CONDITIONAL(GLIBCPP_BUILD_ABI_CHECK, test "$enable_abi_check" = yes)
>
> AC_CACHE_SAVE
I believe this change might be problematic; this is a request for
clarification.
As it stands, enable_abi_check is always set to yes, except for cygwin.
We need some kind of check for native-vs-cross, unless you really mean
to allow abi_check for cross compilers. (Although the way I had it was
backwards, go figure.)
Phil
--
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace. We seek
not your counsel, nor your arms. Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen. - Samuel Adams