This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: patch: convert_move

From: Aldy Hernandez <aldyh at redhat dot com>
To: Richard Henderson <rth at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 13 Jun 2003 18:22:36 -0400
Subject: Re: patch: convert_move

On Friday, June 13, 2003, at 06:16 PM, Richard Henderson wrote:

On Fri, Jun 13, 2003 at 01:16:45PM -0400, Aldy Hernandez wrote:
! sum = (sum << shift) + INTVAL (elt) & unit_mask;
Almost ok.  You've got a precedence problem here;
need parenthesis around the and operation.

Worry not, the warning patrol took care about notifying me about that ;-). I had since fixed it.

+ s64 = __ev_convert_s64 ((v2si){0,0xffffffff});
Clearly you need a different test case as well, so that
you'd have seen that bug.

Who? What? That's the testcase I have here and it exhibits the problem without the patch.

Aldy

Follow-Ups:
- Re: patch: convert_move
  - From: Daniel Jacobowitz

References:
- Re: patch: convert_move
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]