This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] alias.c: Replace "return NULL_RTX" with "return 0".



On Thursday, Jun 12, 2003, at 14:13 US/Eastern, Kazu Hirata wrote:


Hi,

Attached is a patch to replace "return NULL_RTX" with "return 0".

In the past, there were some arguments to prefer 0 to NULL_RTX, such
as

http://gcc.gnu.org/ml/gcc-patches/2001-03/msg01566.html

One of the problems that were pointed out was that arguments to
variadic functions need to be typed, but return values should have no
problem because they are always typed.

I could do a massive automated replace, but I chose to manually check
the actual return type just in case and go through files one by one.

Bootstrapped on i686-pc-linux-gnu. OK to apply?


If I had a say, I would say no because return NULL_RTX is more clearer than return 0 and what it returns and why
and also recently there was a problem with using 0 lately see <http://gcc.gnu.org/ml/gcc-patches/2003-02/msg01006.html>
on where the problem was (in fact using NULL did not always worked also).



Thanks, Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]