This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[libstdc++] Cleanup notes, rename iterator parameters


This patch is large but simpleminded, and almost completely cosmetic.

Parts of the code use "_Iter" in template arguments to refer to iterators;
other parts use "_Iterator".  (Plus the obvious derivates on both sides.)
In the ongoing effort to make the generated docs more readable, this
makes all code use the _Iterator style.  Yes, it's a bit longer, but a)
it seemed to be more prevalent in the code already, and b) it's a complete
word, which makes a difference in readability of formal parameters.

(The largest change, linecount-wise, is to stl_algo.h.  Apart from that
the changes are rather minimal.)

Likewise for pos to position, and val to value, in formal arguments.
Local variables are irrelevent to doxygen, so use whatever shortcuts
we like.  :-)

The BUGS and CHECKLIST files are updated.  Most of the CHECKLIST changes
are whitespace cosmetics.  The rest are dealing with the "implementation
defined" status of container's iterators, now that those issues have been
largely dealt with.

Couple of cosmetic fixes elsewhere.  Finally, _STL_auto_lock is marked as
possibly unused, since it does all its work in the *tors.

Tested on x86-linux, no regressions.


2003-06-10  Phil Edwards  <pme@gcc.gnu.org>

	* docs/html/17_intro/BUGS:  Update from 2.90.8 snapshot.
	* docs/html/17_intro/CHECKLIST:  Bring up to date with respect to
	correctness of container::iterator typedefs.  Fix whitespace.
	* docs/html/20_util/howto.html, docs/html/ext/howto.html:  Add links
	to allocator docs.
	* docs/html/documentation.html:  Regenerate.

	* include/bits/basic_string.h, include/bits/basic_string.tcc,
	include/bits/deque.tcc, include/bits/list.tcc, include/bits/stl_algo.h,
	include/bits/stl_algobase.h, include/bits/stl_bvector.h,
	include/bits/stl_deque.h, include/bits/stl_iterator_base_funcs.h,
	include/bits/stl_list.h, include/bits/stl_uninitialized.h,
	include/bits/stl_vector.h, include/bits/vector.tcc,
	include/ext/algorithm, include/ext/slist, include/std/std_bitset.h:
	Change _Iter names to _Iterator, and __pos to __position.

	* include/bits/stl_relops.h, include/bits/stl_numeric.h,
	include/bits/stl_multiset.h, include/bits/stl_set.h:
	Remove emacs markers.

	* include/bits/stl_threads.h (_STL_auto_lock):  Add __unused__.

Attachment: toobig.patch.bz2
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]