This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Value profile based optimizations, part 1
- From: Zdenek Dvorak <rakdver at atrey dot karlin dot mff dot cuni dot cz>
- To: Andreas Jaeger <aj at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org, jh at suse dot cz, nathan at codesourcery dot com
- Date: Mon, 9 Jun 2003 00:02:25 +0200
- Subject: Re: [PATCH] Value profile based optimizations, part 1
- References: <20030426220941.GA14611@atrey.karlin.mff.cuni.cz> <3EABD519.10607@codesourcery.com> <20030427163514.GA5895@atrey.karlin.mff.cuni.cz> <3EAE8A13.8010109@codesourcery.com> <20030429153741.GA20897@atrey.karlin.mff.cuni.cz> <3EB3BA9E.4070106@codesourcery.com> <20030503215839.GA7007@atrey.karlin.mff.cuni.cz> <3EB51BF4.6030706@codesourcery.com> <20030608204856.GA23446@atrey.karlin.mff.cuni.cz> <u8d6hos1lo.fsf@gromit.moeb>
Hello,
> > static void insn_values_to_profile PARAMS ((rtx, unsigned *,
> > struct histogram_value **));
>
> Can you use ISO C 90 prototypes everywhere? With a new file, we do
> not need to use PARAMS or ...
> > [...]
> > /* Find list of values for that we want to measure histograms. */
> > void
> > find_values_to_profile (n_values, values)
> > unsigned *n_values;
> > struct histogram_value **values;
>
> this.
of course; I have just missed these two cases (I hope).
Zdenek
> > {
> > rtx insn;
> > unsigned i;
> >
> > *n_values = 0;
> > *values = NULL;
> > for (insn = get_insns (); insn; insn = NEXT_INSN (insn))
> > insn_values_to_profile (insn, n_values, values);
> >
> > for (i = 0; i < *n_values; i++)
> > {
> > switch ((*values)[i].type)
> > {
> > case HIST_TYPE_INTERVAL:
> > (*values)[i].n_counters = (*values)[i].hdata.intvl.steps +
> > ((*values)[i].hdata.intvl.may_be_less ? 1 : 0) +
> > ((*values)[i].hdata.intvl.may_be_more ? 1 : 0);
>
> AFAIR according to the coding styles this should be wrapped around
> with the + at the beginning of the line and not at the end.
>
>
> Andreas
> --
> Andreas Jaeger
> SuSE Labs aj@suse.de
> private aj@arthur.inka.de
> http://www.suse.de/~aj