This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Properly support SSE2 intrinsics


On Tue, Jun 03, 2003 at 04:09:35PM -0700, Richard Henderson wrote:
> On Tue, Jun 03, 2003 at 11:52:11AM -0700, H. J. Lu wrote:
> > +/* Alternate intrinsic name definitions.  */
> > +#define	_m_empty	_mm_empty
> 
> I do not think that this is the best way to do this.
> I'd much rather we used *another* inline function so
> as to not pollute the namespace.

I will do that.

> 
> > +/* For backward source compatibility.  */
> > +#include <emmintrin.h>
> 
> Except that you have emmintrin.h including xmmintrin.h.
> So which is it supposed to be?
> 

All SSE2 intrinsics are moved into emmintrin.h. That line is for gcc
backward source compatibility only. It does look odd. It works since
both emmintrin.h and xmmintrin.h are protected by #ifndef/#define.
I can remove that line if gcc 3.3 source compatibility is not
needed.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]