This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to stop setting -Wno-error on varasm.o


 > From: Geoff Keating <geoffk@geoffk.org>
 > 
 > "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
 > 
 > > I tested for varasm.c warnings in all cross-configurations.  AFAICT,
 > > only one warning remains and it happens only when configuring for
 > > c4x-unknown-rtems, but since -Werror is only active in stage2 (or
 > > later) and I believe c4x is a cross-only target, it shouldn't matter.
 > 
 > It'd be nice to get rid of that warning too, but I agree it shouldn't
 > matter.

I left that one in as a mild form of protest. :-)

Kinda hoping other folks would get on board before I activate it for
stage1 or cross-compiles and force the issue.  A lot of the cross-only
targets are still pretty dirty warning-wise, especially in the insn-*
files.


 > > Also bootstrapped C-only on sparc-sun-solaris2.7 and verified that we
 > > no longer get -Wno-error on varasm.o in stage2 and later.
 > > 
 > > Ok for mainline?
 > 
 > Please also delete the varasm.o-warn definition in config/rs6000/t-rs6000,
 > and check for the same thing in any other target; with that change, OK.


Thanks.  Other targets seem ok, but t-rs6000 also can get rid of
out_object_file.  Here's what I checked in.


2003-06-04  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

	* Makefile.in (varasm.o): Don't set -Wno-error.
	* rs6000/t-rs6000 (varasm.o, out_object_file): Don't clear.

diff -rup orig/egcc-CVS20030604/gcc/Makefile.in egcc-CVS20030604/gcc/Makefile.in
--- orig/egcc-CVS20030604/gcc/Makefile.in	2003-06-04 13:25:22.000000000 -0400
+++ egcc-CVS20030604/gcc/Makefile.in	2003-06-04 19:12:54.630621897 -0400
@@ -158,7 +158,6 @@ GCC_WARN_CFLAGS = $(LOOSE_WARN) $($(@D)-
 
 # These files are to have -Werror bypassed in stage2:
 # These are very hard to completely clean due to target complexities.
-varasm.o-warn = -Wno-error
 gcc.o-warn = -Wno-error
 insn-conditions.o-warn = -Wno-error
 # Bison-1.75 output often yields (harmless) -Wtraditional warnings
diff -rup orig/egcc-CVS20030604/gcc/config/rs6000/t-rs6000 egcc-CVS20030604/gcc/config/rs6000/t-rs6000
--- orig/egcc-CVS20030604/gcc/config/rs6000/t-rs6000	2003-02-01 18:46:47.000000000 -0500
+++ egcc-CVS20030604/gcc/config/rs6000/t-rs6000	2003-06-04 19:13:13.469590599 -0400
@@ -16,6 +16,4 @@ rs6000-c.o: $(srcdir)/config/rs6000/rs60
 	$(CC) -c $(ALL_CFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $(srcdir)/config/rs6000/rs6000-c.c
 
 # The rs6000 backend doesn't cause warnings in these files.
-varasm.o-warn =
 insn-conditions.o-warn =
-$(out_object_file)-warn =


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]