This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to stop setting -Wno-error on varasm.o
- From: Geoff Keating <geoffk at geoffk dot org>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 04 Jun 2003 15:05:49 -0700
- Subject: Re: Patch to stop setting -Wno-error on varasm.o
- References: <200306042152.RAA21149@caip.rutgers.edu>
"Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
> I tested for varasm.c warnings in all cross-configurations. AFAICT,
> only one warning remains and it happens only when configuring for
> c4x-unknown-rtems, but since -Werror is only active in stage2 (or
> later) and I believe c4x is a cross-only target, it shouldn't matter.
It'd be nice to get rid of that warning too, but I agree it shouldn't
matter.
> Also bootstrapped C-only on sparc-sun-solaris2.7 and verified that we
> no longer get -Wno-error on varasm.o in stage2 and later.
>
> Ok for mainline?
Please also delete the varasm.o-warn definition in config/rs6000/t-rs6000,
and check for the same thing in any other target; with that change, OK.
> 2003-06-04 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
>
> * Makefile.in (varasm.o): Don't set -Wno-error.
>
> diff -rup orig/egcc-CVS20030604/gcc/Makefile.in egcc-CVS20030604/gcc/Makefile.in
> --- orig/egcc-CVS20030604/gcc/Makefile.in 2003-06-04 04:35:32.000000000 -0400
> +++ egcc-CVS20030604/gcc/Makefile.in 2003-06-04 17:01:12.030186808 -0400
> @@ -158,7 +158,6 @@ GCC_WARN_CFLAGS = $(LOOSE_WARN) $($(@D)-
>
> # These files are to have -Werror bypassed in stage2:
> # These are very hard to completely clean due to target complexities.
> -varasm.o-warn = -Wno-error
> gcc.o-warn = -Wno-error
> insn-conditions.o-warn = -Wno-error
> # Bison-1.75 output often yields (harmless) -Wtraditional warnings
>
--
- Geoffrey Keating <geoffk@geoffk.org>