This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
PATCH: Remove embedded Tcl code from g++.dg/abi/vague1.C
- From: Mark Mitchell <mark at codesourcery dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Wed, 4 Jun 2003 08:40:46 -0700
- Subject: PATCH: Remove embedded Tcl code from g++.dg/abi/vague1.C
- Reply-to: mark at codesourcery dot com
This patch removes embedded Tcl code from g++.dg/abi/vague1.C, relying
instead on an "xfail" selector.
It is better not to be running different sets of tests on different
platforms anyhow. (And the "dg" test framework should probably
provide a target selector syntax for expressing "not on this target".)
Ideally, this test would be re-expressed by linking with another file
which tries to reference the static data member by referring to its
mangled name. The program should fail to link. (That would eliminate
the weird HPUX difference in behavior on this test.) However, we
don't presently have infrastructure for expressing that kind of test
in a clean way.
Tested on i686-pc-linux-gnu, applied on the mainline.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
2003-06-04 Mark Mitchell <mark@codesourcery.com>
* g++.dg/abi/vague1.C: Use xfail, rather than embedded Tcl code.
Index: g++.dg/abi/vague1.C
===================================================================
RCS file: /cvs/gcc/gcc/gcc/testsuite/g++.dg/abi/vague1.C,v
retrieving revision 1.2
diff -c -5 -p -r1.2 vague1.C
*** g++.dg/abi/vague1.C 13 Nov 2002 23:06:03 -0000 1.2
--- g++.dg/abi/vague1.C 4 Jun 2003 15:33:46 -0000
***************
*** 1,13 ****
// Test that we don't emit unneeded copies of static data member template
// instantiations.
// Disable debug info so we don't get confused by the symbol name there.
- // The test fails on hppa*-*-hpux* because the symbol _ZN1AIiE1tE is imported.
// { dg-options "-g0" }
! // { dg-final { if { [istarget hppa*-*-hpux*] } { return } } }
! // { dg-final { scan-assembler-not "_ZN1AIiE1tE" } }
template <class T> struct A {
static const T t = 0;
};
--- 1,12 ----
// Test that we don't emit unneeded copies of static data member template
// instantiations.
// Disable debug info so we don't get confused by the symbol name there.
// { dg-options "-g0" }
! // The test fails on hppa*-*-hpux* because the symbol _ZN1AIiE1tE is imported.
! // { dg-final { scan-assembler-not "_ZN1AIiE1tE" { xfail hppa*-*-hpux* } } }
template <class T> struct A {
static const T t = 0;
};