This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: Fix pch/system-1.c failures for systems with non-trivial BUILD_VA_LIST_TYPE
- From: Neil Booth <neil at daikokuya dot co dot uk>
- To: Joern Rennecke <joern dot rennecke at superh dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 2 Jun 2003 22:37:35 +0100
- Subject: Re: RFA: Fix pch/system-1.c failures for systems with non-trivial BUILD_VA_LIST_TYPE
- References: <3EDBC03B.ABEFBB48@superh.com>
Joern Rennecke wrote:-
> if (filename)
> {
> add_name_attribute (die, filename);
> ! if (filename[0] != DIR_SEPARATOR)
> add_comp_dir_attribute (die);
> }
>
> --- 11491,11497 ----
> if (filename)
> {
> add_name_attribute (die, filename);
> ! if (filename[0] != DIR_SEPARATOR && strcmp (filename, "<built-in>") != 0)
> add_comp_dir_attribute (die);
> }
Comparing strings to <built-in> is always a bug. Is your whole patch
really the right fix?
Neil.