This is the mail archive of the
mailing list for the GCC project.
Re: [RFA/C] Break out C options into a separate file
- From: Graham Stott <graham dot stott at btinternet dot com>
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Cc: neil at daikokuya dot co dot uk, gcc-patches at gcc dot gnu dot org, toa at pop dot agri dot ch
- Date: Sun, 01 Jun 2003 16:35:05 +0100
- Subject: Re: [RFA/C] Break out C options into a separate file
- References: <20030520221643.GB32072@daikokuya.co.uk> <Pine.LNX.email@example.com> <20030522195154.GA6157@daikokuya.co.uk> <3ED9AAC3.firstname.lastname@example.org> <20030601132012.GC743@daikokuya.co.uk> <200306011526.LAA23364@caip.rutgers.edu>
Kaveh R. Ghazi wrote:
> I've applied this.
> * opts.sh: Remove path from sort.
Neil, I'm having lots of problems with your new code. Issues 3 & 4
lead me to assume you checked in the wrong version of the patch and/or
got something confused when testing it cause I don't see how it could
have possibly worked. So far here are the problems I've encountered.
c-options.c gets included in c-opts.c
3. When I substitute gawk the script runs. However the resulting
c-options.[ch] files cannot be compiled. c-options.c doesn't
include c-options.h so it doesn't know about the cl_options
What part of the build is trying to compile "c-options.c"?
c-options.c:3: warning: array type has incomplete element type
c-options.c:3: error: elements of array `cl_options' have incomplete type
These get defined on c-opts.c before c-options.c gets included
4. If I hack opts.sh to insert #include "c-options.h" in c-options.c,
then I get another error. The CL_* stuff are macros defined in
c-opts.c, but not in c-options.[ch]. They need to be in a header:
c-options.c:7: error: `CL_C' undeclared here (not in a function)
c-options.c:7: error: `CL_OBJC' undeclared here (not in a function)
c-options.c:7: error: `CL_CXX' undeclared here (not in a function)
c-options.c:7: error: `CL_OBJCXX' undeclared here (not in a function)
At this point I gave up. Would you please take a look and ensure
everything works correctly?
Kaveh R. Ghazi email@example.com