This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: money_get should heed frac_digits


>In tfrac-diffs.txt, I've presented one approach to correct this.  There is one
>curious issue in the fix, though---the name "__sep_pos" is no longer correct.
>It's being used both to note the thousands separator and, now, how far we've
>gone past the decimal-point that came.

Looks excellent, thanks.

>Another approach, aside from renaming it, is actually using a new variable to
>count how far we've come since the decimal-point, and thus keeping them
>separated.

I don't feel strongly about this. I think what you've got now seems
fine, and understandable.

This testsuite entry would go in as

testsuite/22_locale/money_get/get/wchar_t/9.cc

Usually we try to test both char and wchar_t instantiations. Thanks!

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]