This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fixinc for Solaris 2.5.1


Eric Botcazou wrote:
> 
> > Please use ``c-fix = format'' instead of ``sed = ''.  e.g.:
> >
> >     c-fix = format;
> >     c-fix-arg = '^extern [pid_tn]+ getpgid\(.*';
> >     c-fix-arg = "%0\nextern int getpagesize();";
> >
> > It will never set the arg list to "void", but that won't hurt, either.
> 
> Are you sure? -Wstrict-prototypes will certainly find it and -Werror will
> stop the bootstrap.

I may be wrong, but it shouldn't.  Such warnings should be disabled
in the system headers.

> > >         * fixinc/check.tpl: Use 'diff -c', not 'diff -u'.
> >
> > It's taken a long time to find that one!  Thanks.
> 
> Note that I get failures after 'make check' on Solaris 2.5.1 in unrelated
> headers because of spurious whitespaces. Can't '-b' be passed to 'diff'?

They flat out don't work on BSD.  If passing -b to diff fixes the problems
you see, then please email me confirmation & we'll add it.  I don't think
the BSD sed issue is fixable because it produces different results.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]