This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fixinc for Solaris 2.5.1


Eric Botcazou wrote:
> 2003-05-24  Eric Botcazou  <ebotcazou@libertysurf.fr>
> 
>         * fixinc/inclhack.def: Add missing declaration of getpagesize()
>         to <unistd.h> on Solaris 2.5.1.

Please use ``c-fix = format'' instead of ``sed = ''.  e.g.:

    c-fix = format;
    c-fix-arg = '^extern [pid_tn]+ getpgid\(.*';
    c-fix-arg = "%0\nextern int getpagesize();";

It will never set the arg list to "void", but that won't hurt, either.
Also, the test-text contains the answer.  The test-text needs to
be an example of a broken header (i.e. *NOT* have getpagesize):

    test-text = '#ident "@(#)unistd.h   1.33    95/08/28 SMI"' "\n"
                'extern pid_tn getpgid(pid_t); /* xxx */';

>         * fixinc/tests/base/unistd.h: Add solaris_unistd fix test.

This will need to be reworked.

>         * fixinc/check.tpl: Use 'diff -c', not 'diff -u'.

It's taken a long time to find that one!  Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]