This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: GCC 3.3 Released
- From: Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>
- To: Mark Mitchell <mark at codesourcery dot com>,"Joseph S. Myers" <jsm28 at cam dot ac dot uk>
- Cc: Jie Zhang <zhangjie at magima dot com dot cn>, gcc at gcc dot gnu dot org,gcc-patches at gcc dot gnu dot org
- Date: Sat, 24 May 2003 00:57:57 +0200 (CEST)
- Subject: Re: GCC 3.3 Released
- References: <200305142345.h4ENjScJ002366@doubledemon.codesourcery.com><3EC31DB2.3090300@magima.com.cn> <Pine.BSF.4.55.0305151627110.16396@naos.dbai.tuwien.ac.at><Pine.LNX.4.53.0305152314510.14207@kern.srcf.societies.cam.ac.uk>
On Thu, 15 May 2003, Mark Mitchell wrote:
>>> There are four entries for GCC 3.3 release in all ChangeLogs. Like this:
> Let's give it a try. Please put it on the mainline. If you would,
> would you also updates release.html to say "For the GCC 3.4 release,
> verify that at least one ChangeLog entry has been created by the release
> script?" I'll remove that once 3.4 is out.
I have now committed the modified patch below...
On Thu, 15 May 2003, Joseph S. Myers wrote:
> You can test this sort of thing against an rsynced copy of the repository
> (so it needn't wait for 3.4 to come into effect, or require any artificial
> extra entries on the release instructions).
...and verified the patch by repeatedly running the script for GCC 3.3.9
and 3.3.10 (locally, of course <g>).
Mark, do you want the note in releasing.html nevertheless? And should
this go to the 3.3-branch as well to avoid duplicate ChangeLog entries
there?
Gerald
2003-05-24 Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
* gcc_release (build_sources): Only update ChangeLog files which
do not yet contain the entry we are going to add.
Fix typo in added ChangeLog entries.
Index: gcc_release
===================================================================
RCS file: /cvs/gcc/gcc/maintainer-scripts/gcc_release,v
retrieving revision 1.24
diff -u -5 -p -r1.24 gcc_release
--- gcc_release 20 May 2003 11:47:50 -0000 1.24
+++ gcc_release 23 May 2003 22:51:28 -0000
@@ -120,21 +120,26 @@ build_sources() {
${CVS} co -d "`basename ${SOURCE_DIRECTORY}`" \
-r ${BRANCH} gcc || \
error "Could not check out release sources"
for x in `find ${SOURCE_DIRECTORY} -name ChangeLog`; do
- cat - ${x} > ${x}.new <<EOF
+ # Update this ChangeLog file only if it does not yet contain the
+ # entry we are going to add. (This is a safety net for repeated
+ # runs of this script for the same release.)
+ if ! grep "GCC ${RELEASE} released." ${x} > /dev/null ; then
+ cat - ${x} > ${x}.new <<EOF
${LONG_DATE} Release Manager
- * GCC ${RELEASE} Released.
+ * GCC ${RELEASE} released.
EOF
- mv ${x}.new ${x} || \
- error "Could not update ${x}"
- (changedir `dirname ${x}` && \
- ${CVS} ci -m 'Mark ChangeLog' `basename ${x}`) || \
- error "Could not commit ${x}"
+ mv ${x}.new ${x} || \
+ error "Could not update ${x}"
+ (changedir `dirname ${x}` && \
+ ${CVS} ci -m 'Mark ChangeLog' `basename ${x}`) || \
+ error "Could not commit ${x}"
+ fi
done
# Update `gcc/version.c'.
for x in gcc/version.c; do
y=`basename ${x}`