This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Resubmit: New lang hook: ok_for_sibcall


On 22-May-2003, Andrew Haley <aph@redhat.com> wrote:
> Fergus Henderson writes:
>  > On 21-May-2003, Andrew Haley <aph@redhat.com> wrote:
>  > > This is a repost of the patch I posted eariler.  This diff is against
>  > > mainline rather than branch.
>  > 
>  > You should update the comments as well as the code.
>  > In particular the comments that you added in langhooks.{c,h}
>  > are misleading, IMHO.
> 
> The only thing I think you can mean is that the comment doesn't say
> "DECL may be null" I'll add that when I commit, but to save confusion
> I won't re-submit the patch again.

As well as that, it should explain what DECL being null means,
i.e. what the langhook is supposed to do when called with a null DECL.

-- 
Fergus Henderson <fjh@cs.mu.oz.au>  |  "I have always known that the pursuit
The University of Melbourne         |  of excellence is a lethal habit"
WWW: <http://www.cs.mu.oz.au/~fjh>  |     -- the last words of T. S. Garp.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]