This is the mail archive of the
mailing list for the GCC project.
Re: RFA: fix gcc.dg/torture/builtin-noret-2.c for sh-elf
Joern Rennecke <firstname.lastname@example.org> writes:
> Zack Weinberg wrote:
>> Joern Rennecke <email@example.com> writes:
>> > * gcc.dg/torture/builtin-noret-2.c (_exit): Make weak.
>> #pragma weak is not recognized on all targets where weak symbols are
>> meaningful. I think you can use attribute weak instead, but please
>> check that that won't cause an error on a target without weak symbols.
> It causes an extra warning on sh-coff:
Hrm. The #pragma is recognized if HANDLE_SYSV_PRAGMA, one of the
ASM_WEAKEN_* macros, and SUPPORTS_WEAK are all set. This strikes me
as silly. We should recognize #pragma weak whenever weak symbols are
meaningful. Would you be willing to prepare a patch to that effect?
Another note on your original patch: whatever ends up being done, I
think _Exit needs the same treatment.