This is the mail archive of the
mailing list for the GCC project.
Re: Patch to eliminate uses of `0' flag in asm_fprintf calls
"Kaveh R. Ghazi" <email@example.com> writes:
> > From: Geoff Keating <firstname.lastname@example.org>
> > "Kaveh R. Ghazi" <email@example.com> writes:
> > > I raised a question regarding these `0' flags here:
> > > http://gcc.gnu.org/ml/gcc/2003-05/msg02006.html
> > >
> > > Assuming these zeros are bogus, ok for mainline?
> > How did you test this patch?
> Sorry. I tested it by building cross-compilers targetted to
> m68hc11-unknown-elf and m68k-unknown-linux-gnu and looking for
> warnings. The host compiler had my asm_fprintf checking patch applied
> so it originally flagged these cases, and when I removed the zeros the
> warnings went away.
> Assuming the zeros are in fact bogus, I believe this patch is correct,
> otherwise I'll update my checking patch to accept %0I. However my
> visual inspection of asm_fprintf in final.c leads me to believe the
> zero has no effect.
I'm pretty sure you're right. The patch is OK.
- Geoffrey Keating <firstname.lastname@example.org>