This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Updated --with-cpu patches...


Hate to nitpick after all your work, but...

The tab-heavy indentation style in config.gcc sucks, and doesn't 
correspond to the indentation style used in any of our other shell 
scripts (two or four space indents).

As long as you're poking huge amounts of the code anyway, how about 
making the indentation reasonable in the parts you're poking?... I was 
told not to because large diffs make branch merges hard.  But with large 
diffs anyway...

--Nathanael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]