This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR bootstrap/10169: Prototype getopt in mips-tfile.c


> Unfortunately, when mips-file is being built the order of include
> directories has changed and "stdio.h" instead pulls in libiberty's
> getopt.h,

I think changing this is the proper fix for this problem.  System
headers shouldn't be pulling local headers.

Adding a host-specific change to a target-specific file is, IMHO,
always the wrong thing to do.  In this case, it will also cause
problems when the host provides a getopt prototype that conflicts with
the one you added.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]