This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: binutils without a date is not handled properly without GNU sed

On Thu, May 15, 2003 at 01:08:16AM -0500, Loren James Rittle wrote:
> $(ld_vers) is later parsed with expr in a manner that tolerates extra
> dotted numbers after the patch level.  I.e. the above final proposal
> would handle the various mutant binutils which add a 4th and 5th
> number to the dotted version number...
> Permission to apply to mainline?

Certainly not, this breaks the test.
There were binutils releases which did not have proper
hidden support.
If your sed cannot handle \|, then you might try to split setting ld_vers
into all the alternatives (ie. ld_vers=first_alternative;
test -z "$ld_vers" && ld_vers=second_alternative, etc.).

> 	* (ld_vers): Simplify sed regexp for portability.
> 	* configure: Regenerated.
> Index: gcc/
> ===================================================================
> RCS file: /cvs/gcc/gcc/gcc/,v
> retrieving revision 1.668
> diff -r1.668
> 1850c1850
> <                ld_vers=`echo $ld_ver | sed -n 's,^.*[  ]\([0-9][0-9]*\.[0-9][0-9]*\(\|\.[0-9][0-9]*\(\|\.[0-9][0-9]*\)\)\)\([  ].*\|\)$,\1,p'`
> ---
> >                ld_vers=`echo $ld_ver | sed -n 's,^.*[	 ]\([0-9][0-9]*\.[0-9][0-9.]*[0-9]\).*$,\1,p'`


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]