This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: TOPLEVEL PATCH: accept more x86 variants


> ---=_webmail-1.dnv.wideopenwest.com3ec295fd
> Content-Type: application/octet-stream; name="toplevel_x86.diff"
> Content-Transfer-Encoding: base64
> Content-Disposition: attachment; filename="toplevel_x86.diff"

Note that, in general, it's preferable to explicitly list each
character, in case locales or encodings rearrange the order of
characters (like EBCDIC does).  While it doesn't matter in this case,
it's probably better to avoid ranges so that people don't get the idea
that they're OK for all cases.

Your patch is acceptable as-is, but if you could take the time to
expand the ranges, that would be a little better for long-term
portability.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]