This is the mail archive of the
mailing list for the GCC project.
Re: TOPLEVEL PATCH: accept more x86 variants
- From: DJ Delorie <dj at redhat dot com>
- To: kelleycook at wideopenwest dot com
- Cc: binutils at sources dot redhat dot com, gcc-patches at sources dot redhat dot com, gdb-patches at sources dot redhat dot com, cc at wideopenwest dot com
- Date: Wed, 14 May 2003 20:20:37 -0400
- Subject: Re: TOPLEVEL PATCH: accept more x86 variants
- References: <email@example.com>
> Content-Type: application/octet-stream; name="toplevel_x86.diff"
> Content-Transfer-Encoding: base64
> Content-Disposition: attachment; filename="toplevel_x86.diff"
Note that, in general, it's preferable to explicitly list each
character, in case locales or encodings rearrange the order of
characters (like EBCDIC does). While it doesn't matter in this case,
it's probably better to avoid ranges so that people don't get the idea
that they're OK for all cases.
Your patch is acceptable as-is, but if you could take the time to
expand the ranges, that would be a little better for long-term