This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix dealing with large (>2GB) static data initalizers


> A couple of comments on your patch:
> 
> 1.  You're still not taking full advantage of the possible range.  Why
>     not use `unsigned HOST_WIDE_INT' and HOST_WIDE_INT_PRINT_UNSIGNED
>     throughout instead of the signed counterparts?
OK, I will do the replacement.  It easy.
>   
> Careful, you seem to have missed the leading comma.
> 
> 3.  What's with the backquotes around the \n in the call to putc
> below?  You did the same in several more places following this one.

I will fix these two (and use string concatenation).  Iterestlingly
enought I was fixing the reversed quotes once before (the patch was made
on Spanish keyboard that made me go crazy).  Thanks!

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]