This is the mail archive of the
mailing list for the GCC project.
Re: Configure option and program transform name
- From: DJ Delorie <dj at redhat dot com>
- To: eager at mvista dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 9 May 2003 20:55:26 -0400
- Subject: Re: Configure option and program transform name
- References: <3EBC48A9.EACB7C7C@mvista.com>
> This patch fixes a problem with parsing configure options when
> there is a special character in the option. When you have an option
> like --program-transform-name=s,^,prefix-, baseargs is built up with
> quotes around the argument. Unfortunately, the sed script which is
> supposed to strip out selected options also eliminates any option
> which starts with a quote.
This part is OK. If you can, please make sure this change is
committed to both gcc and src, since they're in sync.
> This also sets program-transform-cross-name to use the same sed
> script as program-transform-name.
I don't think this is the right thing to do.
program-transform-cross-name is used to find the cross-assembler et
al, and the right way to override those is to set them in the
environment (i.e. AR_FOR_TARGET=foo-ar). It is a completely different
purpose than program-transform-name. I think the only way we can get
away with your change is if we also supported overriding
program_transform_cross_name from the toplevel configure. There's
also some interaction with the toplevel configure.in looking for
But, if you think it's the right thing to do, I'd at least expect an
enlightened rationale and suitable docs changes.
> 2003-05-09 Michael Eager <firstname.lastname@example.org>
> * configure.in: correct sed script
> * configure: rebuild
> * gcc/Makefile.in: make program-transform-cross-name same
> as program-transform-name
ChangeLog entries should be complete sentences, meaning they should at
least start with a capital letter and end with a period. Continuation
lines should be indented with just a tab, not a tab plus additional
spaces. GCC has its own ChangeLog, so the last entry would just say
"Makefile.in" but would be separate, and go in gcc/ChangeLog.
Also, since these two changes are unrelated, they probably should have
been submitted separately.