This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] TLS support for powerpc/powerpc64 (take 2)


On Sat, May 10, 2003 at 09:31:09AM +0930, Alan Modra wrote:
> On Fri, May 09, 2003 at 03:55:31PM -0700, Richard Henderson wrote:
> > On Fri, May 09, 2003 at 09:30:04AM -0700, Janis Johnson wrote:
> > > +static GTY(()) rtx rs6000_tls_symbol;
> > > +static rtx
> > > +rs6000_tls_get_addr ()
> > > +{
> > > +  if (!rs6000_tls_symbol)
> > > +    rs6000_tls_symbol = gen_rtx_SYMBOL_REF (Pmode, "__tls_get_addr");
> > 
> > You should use init_one_libfunc instead of gen_rtx_SYMBOL_REF
> > so that the proper SYMBOL_REF_FLAGS are set.  I'm surprised
> > that you didn't see problems on the ppc64 port because of this.
> 
> That code preceded your SYMBOL_REF_FLAGS changes..

That and rs6000_got_sym are changed in the version I'm testing now,
which also has the changes that David Edelsohn requested.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]