This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: use mkinstalldirs when installing multilib


On Fri, May 09, 2003 at 10:25:55AM -0400, David Edelsohn wrote:
>          * mklibgcc.in: Use mkinstalldirs when installing multilib
>          directories.
> 
> This patch causes an installation failure on AIX:
> 
> if [ -d /gcc/dje/install/powerpc-ibm-aix4.3.3.0-20030508/lib/gcc-lib/powerpc-ibm-aix4.3.3.0/3.4/pthread ]; then true; else '/usr/gnu/bin/bash /gcc/dje/src/gcc/mkinstalldirs' /gcc/dje/install/powerpc-ibm-aix4.3.3.0-20030508/lib/gcc-lib/powerpc-ibm-aix4.3.3.0/3.4/pthread; chmod a+rx /gcc/dje/install/powerpc-ibm-aix4.3.3.0-20030508/lib/gcc-lib/powerpc-ibm-aix4.3.3.0/3.4/pthread; fi;
> /bin/sh: /usr/gnu/bin/bash /gcc/dje/src/gcc/mkinstalldirs:  not found.
> chmod: /gcc/dje/install/powerpc-ibm-aix4.3.3.0-20030508/lib/gcc-lib/powerpc-ibm-aix4.3.3.0/3.4/pthread: A file or directory in the path name does not exist.
> make[2]: *** [install] Error 1
> make[2]: Leaving directory `/gcc/dje/build/powerpc-ibm-aix4.3.3.0-20030508/gcc'
> make[1]: *** [install-multilib] Error 2
> make[1]: Leaving directory `/gcc/dje/build/powerpc-ibm-aix4.3.3.0-20030508/gcc'
> make: *** [install-gcc] Error 2
> gcc_build: error: Installation failed
> 
> Is this implemented safely for parallel Make?

The quoting is broken.  The following patch should fix it.  I'll
be offline until Tuesday, so I'd appreciate it if someone else
would test and apply it if approved.

Matt
-- 
Matt Kraai <kraai@alumni.cmu.edu>
Debian GNU/Linux Peon

       * mklibgcc.in: Remove extra quotes.

Index: gcc/mklibgcc.in
===================================================================
RCS file: /cvs/gcc/gcc/gcc/mklibgcc.in,v
retrieving revision 1.60
diff -c -3 -p -r1.60 mklibgcc.in
*** gcc/mklibgcc.in	8 May 2003 20:10:57 -0000	1.60
--- gcc/mklibgcc.in	9 May 2003 14:34:45 -0000
*************** for ml in $MULTILIBS; do
*** 497,503 ****
    flags=`echo ${ml} | sed -e 's/^[^;]*;//' -e 's/@/ -/g'`;
    if [ $dir != . ]; then
      ldir='$(DESTDIR)$(libsubdir)'/$dir
!     echo "	if [ -d $ldir ]; then true; else '$mkinstalldirs' $ldir; chmod a+rx $ldir; fi;"
    else
      ldir='$(DESTDIR)$(libsubdir)'
    fi
--- 497,503 ----
    flags=`echo ${ml} | sed -e 's/^[^;]*;//' -e 's/@/ -/g'`;
    if [ $dir != . ]; then
      ldir='$(DESTDIR)$(libsubdir)'/$dir
!     echo "	if [ -d $ldir ]; then true; else $mkinstalldirs $ldir; chmod a+rx $ldir; fi;"
    else
      ldir='$(DESTDIR)$(libsubdir)'
    fi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]