This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to replace occurrence of Hitachi to Renesas and tosupport -mrenesas in gcc


Hi Rohit,

> @@ -560,7 +560,7 @@
>  -m5-32media -m5-32media-nofpu @gol
>  -m5-compact -m5-compact-nofpu @gol
>  -mb  -ml  -mdalign  -mrelax @gol
> --mbigtable  -mfmovd  -mhitachi  -mnomacsave @gol
> +-mbigtable  -mfmovd  -mrenesas  -mnomacsave @gol
>  -mieee  -misize  -mpadstruct  -mspace @gol
>  -mprefergot  -musermode}
>  
> @@ -8887,14 +8887,14 @@
>  @opindex mfmovd
>  Enable the use of the instruction @code{fmovd}.
>  
> - at item -mhitachi
> - at opindex mhitachi
> -Comply with the calling conventions defined by Hitachi.
> + at item -mrenesas
> + at opindex mrenesas
> +Comply with the calling conventions defined by Renesas (formerly Hitachi).
>  
>  @item -mnomacsave
>  @opindex mnomacsave
>  Mark the @code{MAC} register as call-clobbered, even if
> - at option{-mhitachi} is given.
> + at option{-mrenesas} is given.
>  
>  @item -mieee
>  @opindex mieee

I am not an SH port maintainer, but you might want to say "-mhitachi
is obsolete and will be removed in the next release" or something.

> @@ -21,6 +21,11 @@
>  the Free Software Foundation, 59 Temple Place - Suite 330,
>  Boston, MA 02111-1307, USA.  */
>  
> +/****************************************
> +GCC For the Renesas H8/300
> +Originally developed by Hitachi America Ltd.
> +*****************************************/
> +
>  #include "config.h"
>  #include "system.h"
>  #include "rtl.h"

I would move this after the first five lines of h8300.c and keep
credit to Cygnus.

> @@ -702,8 +704,7 @@
>      else
>        fprintf (file, "\n\t.h8300s\n");
>    else
> -    fprintf (file, "\n\n");
> -  output_file_directive (file, main_input_filename);
> +    fprintf (file, "\n");
>  }
>  
>  /* Output assembly language code for the end of file.  */

Why are you removing this?

If Hitachi and Mitsubishi are merging their semiconductor divisions,
do you need to do the same for M32R port?

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]