This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Call for testers: libiberty/physmem.c

> +#if HAVE_TABLE
> +  {
> +    struct tbl_vmstats vmstats;

Call me paranoid, but can we put a HAVE_SYS_TABLE_H around that also?
"table" doesn't seem unambiguous enough to give me a warm-and-fuzzy
about false positives.

And we should check for machine/hal_sysinfo.h separately.  Linux has
sys/sysinfo.h but not machine/hal_sysinfo.h.  We'd need to use the
"hal" define to protect as well, else we'd try to access 'table' on
linux (it doesn't have one).
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]